All 3 compilers FAIL getfield: missing null check, protected access check, array check; L2 unsupported#556
Open
opencode-agent[bot] wants to merge 1 commit into
Open
Conversation
…heck, array check; L2 unsupported Co-authored-by: LSantha <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec compliance report
Details
l1a Implementation
core/src/core/org/jnode/vm/x86/compiler/l1a/X86BytecodeVisitor.java:1865-1943, plusVirtualStack.java/ItemStack.javavisit_putfieldat line 3744.l1b Implementation
core/src/core/org/jnode/vm/x86/compiler/l1b/X86BytecodeVisitor.java:2256-2338, plusVirtualStack.java/ItemStack.javavisit_putfieldat line 4666.l2 Implementation
core/src/core/org/jnode/vm/x86/compiler/l2/L2ByteCodeSupportChecker.java:187-189,GenericX86CodeGenerator.java:5054-5285UnsupportedOperationException, so L2 never compiles methods with getfield.refobtained but no null test before field access (lines 5086-5256).IllegalArgumentException()with TODO.IllegalArgumentException()with TODO.JVM Spec References (Java SE 6)
Instruction:
getfield(opcode 180 / 0xb4)Operand Stack:
..., objectref → ..., valueLinking Exceptions: Field resolution errors per §5.4.3.2;
IncompatibleClassChangeErrorif resolved field isstaticRuntime Exception:
NullPointerExceptionifobjectrefisnullNotes: Class of
objectrefmust not be an array; protected field access restricted to current class or subclass; cannot access arraylengthfield (usearraylength).Closes #287
opencode session | github run